Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

Fix ShopifyCLI::Theme::DevServer::CdnFonts class to support any font #1837

Merged
merged 2 commits into from
Dec 10, 2021

Conversation

karreiro
Copy link
Contributor

@karreiro karreiro commented Dec 9, 2021

WHY are these changes introduced?

The #1821 PR fixes the font issue for the Assistant font, but other fonts were failing because of the ShopifyCLI::Theme::DevServer::CdnFonts regex as miss including the /assistant suffix.

WHAT is this pull request doing?

Now, the regex does not include the Assistant font suffix anymore.

How to test your changes?

  1. Go to the theme directory
  2. Update the config/settings_data.json file with a different font (e.g., fira_sans_n9)
  3. Run shopify theme serve service
  4. Open the http://127.0.0.1:9292
  5. Check the fonts are now loading as expected

image

Post-release steps

None.

Update checklist

  • I've added a CHANGELOG entry for this PR (if the change is public-facing)
  • I've considered possible cross-platform impacts (Mac, Linux, Windows).
  • I've left the version number as is (we'll handle incrementing this when releasing).
  • I've included any post-release steps in the section above.

@karreiro karreiro requested review from a team, pepicrft, jesalerno84 and macournoyer and removed request for a team December 9, 2021 12:53
@karreiro karreiro linked an issue Dec 9, 2021 that may be closed by this pull request
Copy link
Contributor

@macournoyer macournoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@karreiro karreiro merged commit 5704988 into Shopify:main Dec 10, 2021
@karreiro karreiro deleted the fix-1533-2 branch December 10, 2021 07:56
@hannachen hannachen mentioned this pull request Dec 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shopify hosted fonts don't load via the local preview url
2 participants