This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
Fix ShopifyCLI::Theme::DevServer::CdnFonts
class to support any font
#1837
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The #1821 PR fixes the font issue for the Assistant font, but other fonts were failing because of the
ShopifyCLI::Theme::DevServer::CdnFonts
regex as miss including the/assistant
suffix.WHAT is this pull request doing?
Now, the regex does not include the Assistant font suffix anymore.
How to test your changes?
config/settings_data.json
file with a different font (e.g.,fira_sans_n9
)shopify theme serve
servicePost-release steps
None.
Update checklist