Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

Fix test for #1873: Fix partners ability to login to external shops #1926

Merged
merged 4 commits into from
Jan 13, 2022

Conversation

molly-yu
Copy link
Contributor

@molly-yu molly-yu commented Jan 13, 2022

WHY are these changes introduced?

#1873 had some tests that were failing, so this adds the fixes in.

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Update checklist

  • I've added a CHANGELOG entry for this PR (if the change is public-facing)
  • I've considered possible cross-platform impacts (Mac, Linux, Windows).
  • I've left the version number as is (we'll handle incrementing this when releasing).
  • I've included any post-release steps in the section above.

@molly-yu molly-yu requested review from a team, hannachen and amcaplan and removed request for a team January 13, 2022 17:07
@molly-yu molly-yu merged commit d52ca28 into main Jan 13, 2022
@molly-yu molly-yu deleted the partners-security branch January 13, 2022 17:49
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems January 17, 2022 17:34 Inactive
hannachen pushed a commit that referenced this pull request Jan 25, 2022
Revert #1926 - Fix partners ability to login to external shops
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant