Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

Revert "Fix CORS (Cross-origin resource sharing) errors (#1952)" #1985

Merged
merged 2 commits into from
Jan 28, 2022

Conversation

karreiro
Copy link
Contributor

@karreiro karreiro commented Jan 28, 2022

WHY are these changes introduced?

The CdnAssets middleware, introduced by #1952, was throttling asset requests.

WHAT is this pull request doing?

This PR reverts #1952 to quick fix this issue. On a future PR, it's probably a good idea to use the ShopifyCLI:: ThreadPool to serve assets in the CdnAssets. Still, for now, this PR undo the changes.

How to test your changes?

  • Run shopify theme serve
  • Add many assets that rely on //cdn.shopify.com URLs
  • Notice in the browser console how requests are affected

Before this revert:
before

After this revert:
after

Post-release steps

None.

Update checklist

  • I've added a CHANGELOG entry for this PR (if the change is public-facing)
  • I've considered possible cross-platform impacts (Mac, Linux, Windows).
  • I've left the version number as is (we'll handle incrementing this when releasing).
  • I've included any post-release steps in the section above.

@pinguluk
Copy link

Yep, localhost wasn't loading at all and it was stuck on the .js files. Installed shopify-cli-2.10.1 version and it's working fine again

@joshuaiz
Copy link

Thank you for this fix 💯

@albertoziveri
Copy link

Still not working. Rendering a section in Localhost is still blocked by version 2.10.1
Explained very well here: #1466

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
7 participants