This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
Revert "Fix CORS (Cross-origin resource sharing) errors (#1952)" #1985
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The
CdnAssets
middleware, introduced by #1952, was throttling asset requests.WHAT is this pull request doing?
This PR reverts #1952 to quick fix this issue. On a future PR, it's probably a good idea to use the
ShopifyCLI:: ThreadPool
to serve assets in theCdnAssets
. Still, for now, this PR undo the changes.How to test your changes?
shopify theme serve
Before this revert:
After this revert:
Post-release steps
None.
Update checklist