This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
Make Wasm the default language for scripts #2061
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes https://github.com/Shopify/script-service/issues/4280
WHAT is this pull request doing?
This PR makes it so that when no language is specified in a
shopify script create
command, we default to a Wasm project as opposed to presenting the language selector.It does so by
Script::Form
option[:language]
from the command directly to the create, and default to "wasm" if it is nil.How to test your changes?
Run
shopify script create
and observe that no language prompt is provided. The resulting project should be wasm.Run
shopify script create --language=typescript
. The resulting project should be typescriptUpdate checklist