Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

Make Wasm the default language for scripts #2061

Merged
merged 4 commits into from
Feb 18, 2022
Merged

Conversation

lopert
Copy link
Contributor

@lopert lopert commented Feb 15, 2022

WHY are these changes introduced?

Fixes https://github.com/Shopify/script-service/issues/4280

WHAT is this pull request doing?

This PR makes it so that when no language is specified in a shopify script create command, we default to a Wasm project as opposed to presenting the language selector.

It does so by

  • removing the language question from Script::Form
  • pass the option[:language] from the command directly to the create, and default to "wasm" if it is nil.

How to test your changes?

Run shopify script create and observe that no language prompt is provided. The resulting project should be wasm.
Run shopify script create --language=typescript. The resulting project should be typescript

Update checklist

  • I've added a CHANGELOG entry for this PR (if the change is public-facing)
  • I've considered possible cross-platform impacts (Mac, Linux, Windows).
  • I've left the version number as is (we'll handle incrementing this when releasing).
  • I've included any post-release steps in the section above.

@lopert lopert requested a review from a team as a code owner February 15, 2022 20:10
Copy link
Contributor

@andrewhassan andrewhassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't 🎩 but code LGTM!

Copy link
Contributor

@ErinRenNumber1 ErinRenNumber1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Minor nitpick, we should add to the help text "default to wasm". Like this
Screen Shot 2022-02-16 at 11 17 18 AM

@lopert lopert merged commit b4a741c into main Feb 18, 2022
@lopert lopert deleted the lopert.make-wasm-default branch February 18, 2022 13:39
@lopert lopert mentioned this pull request Feb 18, 2022
4 tasks
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems February 23, 2022 09:55 Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants