Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest v3 + Moving to speedscope #153

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Manifest v3 + Moving to speedscope #153

merged 2 commits into from
Jan 22, 2025

Conversation

madmath
Copy link
Contributor

@madmath madmath commented Jan 17, 2025

What issue does this pull request address?

  • Extension is currently broken due to moving to the new profile format.
  • Extension is on Manifest v2, which is deprecated.

What is the solution

  • Move to Manifest v3
  • Remove custom flamegraph and tests
  • Bring in a speedscope iframe
  • Get speedscope data from SFR and load it in speedscope.

What should the reviewer focus on and are there any special considerations?

Ask me for the zip file that works with our dev environment.

@madmath madmath requested review from mgmanzella and krzksz January 17, 2025 15:34
@madmath madmath force-pushed the manifest-v3-speedscope branch 3 times, most recently from df12b9d to c871f20 Compare January 17, 2025 20:19
@madmath madmath force-pushed the manifest-v3-speedscope branch from c871f20 to 1595fdb Compare January 17, 2025 20:21
@madmath madmath force-pushed the manifest-v3-speedscope branch from 218c65b to 6455921 Compare January 17, 2025 21:49
@madmath madmath merged commit 076fd60 into master Jan 22, 2025
1 check passed
@madmath madmath deleted the manifest-v3-speedscope branch January 22, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants