Re-add deprecated files to prevent major release #1884
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
In #1861, we (correctly) removed some files related to JWT that should no longer be used in
shopify_app
. However, by removing those files we'd be forced to make a major release, which is still a bit too close to the last one.This PR adds back the code that was removed (but will be unused internally) so it doesn't break existing apps. It will log deprecations for them instead.
Log message will look like this
Reviewer's guide to testing
Use this branch in the Gemfile of an app using the ruby template, and set it up to use
ShopifyApp::JWTMiddleware
.Things to focus on