Skip to content

Commit

Permalink
Fix broken test on Ruby 3.1
Browse files Browse the repository at this point in the history
We have a test that was pointing to rails#main; however, main / Rails
8 has dropped support for Ruby 3.1 so the test started failing. The
test does seem valuable so we're pointing to rails#7-2-stable instead.
  • Loading branch information
dirceu committed Oct 2, 2024
1 parent defb823 commit 1614dd8
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion spec/tapioca/cli/gem_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -1530,8 +1530,10 @@ class Application < Rails::Application
# Note that this problem only happens if another gem somehow eager loads the engines. By default, Rails
# would've not loaded those classes and they would have not been placed in the Rails RBI.

# This is pointing to the 7-2-stable branch because Rails 8 dropped support for Ruby 3.1. We can point
# it to main again once Tapioca drops support for Ruby 3.1 as well.
@project.write_gemfile!(<<~GEMFILE, append: true)
gem("rails", git: "https://github.com/rails/rails", branch: "main")
gem("rails", git: "https://github.com/rails/rails", branch: "7-2-stable")
GEMFILE

# Create a gem that eager loads the ActionMailbox engine
Expand Down

0 comments on commit 1614dd8

Please sign in to comment.