Fix Rails head builds #1572
Merged
Fix Rails head builds #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added in Rails here: rails/rails#47490
Rails PR: rails/rails#47010
This is an undocumented method, but it became public in Rails 7.1. Rails PR: rails/rails#47800
vinistock
approved these changes
Jul 20, 2023
bitwise-aiden
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Rails HEAD builds have been having some test failures for some time now, but they pass since they are marked as
experimental.Implementation
The behaviour of Tapioca was already correct, it was the tests that were missing some generated methods, so I added missing generated methods to the test cases.
Tests
Updated tests