Extract multiple commands from Dsl command
#1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'd been using the `Dsl` command to perform three distinct tasks: 1. generate DSL RBI files for specified or all constants/paths 2. verify that the DSL RBI files are up-to-date 3. list DSL compilers All of this functionality bunched together in a single command was making it hard to change behaviour or to add uniform behaviour to all `Command` classes, since not all of them would call the execute method in the end. This commit extracts an abstract dsl command super class and splits the previous `Dsl` command into separate commands that each handle one of these three tasks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We'd been using the
Dslcommand to perform three distinct tasks:All of this functionality bunched together in a single command was making it hard to change behaviour or to add uniform behaviour to all
Commandclasses, since not all of them would call the execute method in the end.Implementation
This PR extracts an abstract dsl command super class and splits the previous
Dslcommand into separate commands that each handle one of these three tasks.Tests
There should be no behaviour change.