Handle fixtures with no associated model #1921
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some projects use YAML files inside the
test/fixtures
directory to represent arbitrary data that is not associated to any specific model.This is a valid use case that Rails allows, but our DSL compiler fails when any fixtures like that are present because it assumes there will be a model.
Implementation
There are essentially two parts to the fix:
fh.model_class
. We don't want generation to stop because we found one of those fixturesmethod_names
so that we can remove invalid fixturesTests
Added a test that reproduces the crash.