Fix idempotence of script tags with backticks and Liquid in 'em #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlespwd
force-pushed
the
fix/162-prettier-script-backticks
branch
from
0d9c079
to
ef163a0
Compare
charlespwd
commented
Oct 10, 2023
| if (shouldIndentBody) { | ||
| return [indent([hardline, body]), hardline]; | ||
| } else { | ||
| return [dedentToRoot([hardline, body]), hardline]; |
There was a problem hiding this comment.
Had to duplicate this logic slightly because it's complicated to explain 😓.
Basically the parent node would not know if we were able to embed or not (i.e. switch rendering from this plugin's to JS, or TypeScript, or whatever). But we need to know if it failed in order to remove the hardlines and print as is without the surrounding hardlines (which we do on line 231).
charlespwd
commented
Oct 10, 2023
| @@ -228,17 +228,30 @@ function printNode( | |||
| }; | |||
|
|
|||
| if (isRawMarkupIdentationSensitive()) { | |||
| return node.value; | |||
| return [node.value.trimEnd(), hardline]; | |||
There was a problem hiding this comment.
This small difference makes the endtag indent properly.
|
Tests pass 🔥 |
This was referenced Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
Fixes #162
before
before.mp4
after
after.mp4
Before you deploy
changesetto this PR