Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change all shopify.dev theme doc #472

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Change all shopify.dev theme doc #472

merged 3 commits into from
Aug 22, 2024

Conversation

PolMrt
Copy link
Contributor

@PolMrt PolMrt commented Aug 15, 2024

What are you adding in this PR?

Change all links to theme docs from shopify.dev/docs/themes/* to shopify.dev/docs/storefronts/themes/* as mentioned in #471.

Note: this overlaps with #470 and #468.

What's next? Any followup issues?

N/A

What did you learn?

N/A

Before you deploy

  • This PR includes a new checks or changes the configuration of a check
    • I included a minor bump changeset
    • It's in the allChecks array in src/checks/index.ts
    • I ran yarn build and committed the updated configuration files
      • If applicable, I've updated the theme-app-extension.yml config
  • I included a minor bump changeset
  • My feature is backward compatible
  • I included a patch bump changeset

@karreiro karreiro self-requested a review August 20, 2024 11:54
Copy link
Contributor

@karreiro karreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @PolMrt! I've noticed only two links that we need to update.

Also, the content_for_block page doesn't exist yet, but I will take care of creating that page.

Thanks again for this PR. With the updates applied, we will be ready to merge 🚀

Copy link
Contributor

@karreiro karreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! I've just applied the changes myself :)

@karreiro karreiro merged commit 01f4a7b into Shopify:main Aug 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants