Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme watch not uploading entire file #31

Closed
thisislawatts opened this issue Feb 19, 2015 · 8 comments · Fixed by #35
Closed

Theme watch not uploading entire file #31

thisislawatts opened this issue Feb 19, 2015 · 8 comments · Fixed by #35

Comments

@thisislawatts
Copy link
Contributor

This is an interesting one, perhaps tied to the size of the file being uploaded. When using theme watch to handle uploading a stylesheet it seems to upload different amounts, my tests show it tends to drop out between lines 567–1700 (approx 45kb)

.pagination-custom-lg > li:first-child > a,
.pagination-custom-lg > li:first-child > span {
  border-bottom-left-radius: 6px;
  border-top-left-ra

No such errors when using theme upload

@csaunders
Copy link
Contributor

Are you using a Unix-like operating system?

Install mitmproxy boot it up and add the following to your config.yml for the appropriate environment:

development:
  proxy: "https://localhost:8080"

@csaunders
Copy link
Contributor

Keep an eye on that and see if anything weird is happening. Feel free to post the response here, but be vigilant to sanitize out any sensitive information (access tokens, etc.)

@thisislawatts
Copy link
Contributor Author

Writing out the contents of mitmdump and it looks like it's not transmitting the complete file, so perhaps it's getting truncated down the line somewhere within the tool? I've got the source so could add some further logging and compile it out, any recommendations on where to start?

Running OSX 10.10.1

# Uploading timber.scss.liquid via `theme watch`
127.0.0.1:63774: clientconnect
127.0.0.1 PUT https://waitandsee.myshopify.com/admin/assets.json
 << 200 OK 239B
127.0.0.1:63774: clientdisconnect
# Uploading timber.scss.liquid via `theme upload`
127.0.0.1:63802: clientconnect
127.0.0.1 PUT https://waitandsee.myshopify.com/admin/assets.json
 << 200 OK 323B
127.0.0.1:63802: clientdisconnect

@csaunders
Copy link
Contributor

that's pretty weird. A 45kb file shouldn't be causing this kind of problem.

I'll test it out with some scss files and some larger ones like an MP3 or something.

@csaunders
Copy link
Contributor

How much have you modified the scss in Timber? If I were to grab the latest release I should be able to replicate the issue pretty easily eh?

@thisislawatts
Copy link
Contributor Author

I had added a hundred lines or so, but then testing again with the unmodified version I was able to recreate it with the original.

Quickly testing it out with https://gist.github.com/thisislawatts/bfbf7c912a9d0abc1301 https://gist.github.com/thisislawatts/bfbf7c912a9d0abc1301 and it bails out between 2000~3400

On 19 Feb 2015, at 13:49, Christopher Saunders notifications@github.com wrote:

How much have you modified the scss in Timber? If I were to grab the latest release I should be able to replicate the issue pretty easily eh?


Reply to this email directly or view it on GitHub #31 (comment).

@thisislawatts
Copy link
Contributor Author

Were you able to recreate this issue on your side?

@csaunders
Copy link
Contributor

I haven't gotten around to it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants