-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme watch not uploading entire file #31
Comments
Are you using a Unix-like operating system? Install development:
proxy: "https://localhost:8080" |
Keep an eye on that and see if anything weird is happening. Feel free to post the response here, but be vigilant to sanitize out any sensitive information (access tokens, etc.) |
Writing out the contents of Running OSX 10.10.1 # Uploading timber.scss.liquid via `theme watch`
127.0.0.1:63774: clientconnect
127.0.0.1 PUT https://waitandsee.myshopify.com/admin/assets.json
<< 200 OK 239B
127.0.0.1:63774: clientdisconnect
# Uploading timber.scss.liquid via `theme upload`
127.0.0.1:63802: clientconnect
127.0.0.1 PUT https://waitandsee.myshopify.com/admin/assets.json
<< 200 OK 323B
127.0.0.1:63802: clientdisconnect |
that's pretty weird. A 45kb file shouldn't be causing this kind of problem. I'll test it out with some scss files and some larger ones like an MP3 or something. |
How much have you modified the scss in Timber? If I were to grab the latest release I should be able to replicate the issue pretty easily eh? |
I had added a hundred lines or so, but then testing again with the unmodified version I was able to recreate it with the original. Quickly testing it out with https://gist.github.com/thisislawatts/bfbf7c912a9d0abc1301 https://gist.github.com/thisislawatts/bfbf7c912a9d0abc1301 and it bails out between 2000~3400
|
Were you able to recreate this issue on your side? |
I haven't gotten around to it yet. |
This is an interesting one, perhaps tied to the size of the file being uploaded. When using
theme watch
to handle uploading a stylesheet it seems to upload different amounts, my tests show it tends to drop out between lines 567–1700 (approx 45kb)No such errors when using
theme upload
The text was updated successfully, but these errors were encountered: