Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fake theme ID in get command for listing #862

Merged
merged 2 commits into from
Dec 3, 2020
Merged

Fake theme ID in get command for listing #862

merged 2 commits into from
Dec 3, 2020

Conversation

tanema
Copy link
Contributor

@tanema tanema commented Dec 3, 2020

fixes #858

While changing get, the them ID shim was removed, making the list action require a theme ID, this removes that requirement

Warn Checklist

  • This changes the interface and requires a Major/Minor version change.
  • I have 🎩'd these changes by using the commands I changed by hand.
  • I have added a dependancy to the project.
  • I have considered any potential impact on node-themekit

@tanema tanema merged commit f5fd478 into master Dec 3, 2020
@tanema tanema deleted the fix_get_command branch December 3, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme get --list stop working properly and versioning is hard to follow
1 participant