Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #857
In previous work, I added in a bunch of arbitrary timeouts, this was because I wanted requests to fail faster if there was an issue. This however was misguided because the actual solution was cancelling the requests. The timeouts were also copied over from our webhook delivery service that I worked on and themekit and that service have vastly different request requirements. Webhook delivery requires fast completion on delivery, however themekit is used to uploading very large files that need more time to complete, so this was done in error.
I have just removed all of these timeouts as the defaults are either pretty large or no timeout is set at all. There is still a general overall request timeout so that does not mean requests will get stuck.
This fix has been confirmed in the issue linked
Warn Checklist