Add redirect to ThemeKit Access when password prefix matches pattern #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanema
approved these changes
May 5, 2021
src/httpify/client.go
Outdated
| @@ -103,7 +106,16 @@ func (client *HTTPClient) Delete(path string, headers map[string]string) (*http. | |||
|
|
|||
| // do will issue an authenticated json request to shopify. | |||
| func (client *HTTPClient) do(method, path string, body interface{}, headers map[string]string) (*http.Response, error) { | |||
| req, err := http.NewRequest(method, client.baseURL.String()+path, nil) | |||
| appBaseURL := client.baseURL.String() | |||
| themeKitPasswordPrefix := "shptka_" | |||
There was a problem hiding this comment.
This should be a constant at the top of the file.
| @@ -27,6 +27,7 @@ var ( | |||
| httpClient = &http.Client{ | |||
| Timeout: 30 * time.Second, | |||
| } | |||
| themeKitAccessURL = "https://theme-kit-access.shopifyapps.com/cli" | |||
There was a problem hiding this comment.
Either make this a constant variable and use it in the Client struct changing the struct in your tests, OR make this a var and reference it in the do method, and alter the var in the tests.
There was a problem hiding this comment.
I prefer the second approach, in that way we avoid modifying HTTPClient struct altogether
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Themekit needs to make requests either to ThemeKit Access or to Shopify depending on the type of password token that user has. This should have no effect for existing Themekit users.
The solution checks whether user token starts with an identifiable prefix
shptka_and redirect all requests to the Theme Kit Access server.Additional context
The issue is related to the new public ThemeKit Access app development.
Warn Checklist