-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release doc #44
Release doc #44
Conversation
Add release doc with step to release a new gem. Update readme to have badges.
``` | ||
gem install toxiproxy | ||
```shell | ||
$ gem install toxiproxy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super minor, but I am not a fan of including $
in command output unless we need to distinguish between typed commands and output being presented to the user.
Advantage of not including the $
is that it makes it easier for people to copy pasta the actual command they need (there's a handy "copy this text" button on Github Markdown boxes) without having to manually remove the preceding $
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is that it makes it easier for people to copy pasta
that exactly the reason why I am adding $. to force people to think before copy paste. It has extra visability - show that it is command line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally github should add it automatically for shell code lines. and have empty lines as separation, but it is not supported for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Aleem on my side :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - and I'm willing to concede on my minor nit because it's precisely that. Minor.
Add release doc with step to release a new gem.
Update readme to have badges.