Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release doc #44

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Release doc #44

merged 1 commit into from
Mar 15, 2022

Conversation

miry
Copy link
Contributor

@miry miry commented Mar 15, 2022

Add release doc with step to release a new gem.
Update readme to have badges.

Add release doc with step to release a new gem.
Update readme to have badges.
@miry miry self-assigned this Mar 15, 2022
@miry miry requested review from a team, djlebersilvestre, tinchi and chopify and removed request for a team March 15, 2022 13:13
```
gem install toxiproxy
```shell
$ gem install toxiproxy
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super minor, but I am not a fan of including $ in command output unless we need to distinguish between typed commands and output being presented to the user.

Advantage of not including the $ is that it makes it easier for people to copy pasta the actual command they need (there's a handy "copy this text" button on Github Markdown boxes) without having to manually remove the preceding $.

Copy link
Contributor Author

@miry miry Mar 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that it makes it easier for people to copy pasta

that exactly the reason why I am adding $. to force people to think before copy paste. It has extra visability - show that it is command line.

Copy link
Contributor Author

@miry miry Mar 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally github should add it automatically for shell code lines. and have empty lines as separation, but it is not supported for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Aleem on my side :P

Copy link

@muz muz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - and I'm willing to concede on my minor nit because it's precisely that. Minor.

@miry miry merged commit 99c9565 into master Mar 15, 2022
@miry miry deleted the release-doc branch March 15, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants