Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The .deb installer is creating executables with arch info in name #330

Closed
SamMorrowDrums opened this issue Oct 4, 2021 · 3 comments · Fixed by #331
Closed

The .deb installer is creating executables with arch info in name #330

SamMorrowDrums opened this issue Oct 4, 2021 · 3 comments · Fixed by #331
Assignees
@miry

Comments

@SamMorrowDrums
Copy link

SamMorrowDrums commented Oct 4, 2021 •
edited
Loading

Hi, I'm wondering if it is deliberate that the build target information is being installed in the debian package. Currently the following get installed:

toxiproxy-server-linux-amd64
toxiproxy-cli-linux-amd64

When running this in our Dockerfile (and note the symlinks to the clean names we had to add):

RUN temporary_toxiproxy_deb=/tmp/toxiproxy.deb && \
  curl --location --fail --output "$temporary_toxiproxy_deb"  https://github.com/Shopify/toxiproxy/releases/download/v2.1.7/toxiproxy_2.1.7_linux_amd64.deb && \
  echo 53604ce8abe95c88709bc11d549d52deb5178858e1faae08fbc389b556c00ce1 "$temporary_toxiproxy_deb" | sha256sum --check --status && \
  dpkg -i "$temporary_toxiproxy_deb" && \
  ln -s /usr/local/bin/toxiproxy-server-linux-amd64 /usr/local/bin/toxiproxy-server  && \
  ln -s /usr/local/bin/toxiproxy-cli-linux-amd64 /usr/local/bin/toxiproxy-cli
@miry miry self-assigned this Oct 4, 2021
miry added a commit that referenced this issue Oct 4, 2021
@miry
Keep linux binaries short
98bcf72 
Closes #330

Linux packages installs binaries to `/usr/local/bin`
and has names:

```
toxiproxy-server-linux-amd64
toxiproxy-cli-linux-amd64
```

It is not common way and different from previous releases.

Changes the binary destination path to `/usr/bin` and has short binary
names:

```
toxiproxy-server
toxiproxy-cli
```
@miry miry mentioned this issue Oct 4, 2021
Merged
miry added a commit that referenced this issue Oct 4, 2021
@miry
Keep linux binaries short
3040cd6 
Closes #330

Linux packages installs binaries to `/usr/local/bin`
and has names:

```
toxiproxy-server-linux-amd64
toxiproxy-cli-linux-amd64
```

It is not common way and different from previous releases.

Changes the binary destination path to `/usr/bin` and has short binary
names:

```
toxiproxy-server
toxiproxy-cli
```
miry added a commit that referenced this issue Oct 4, 2021
@miry
Keep linux binaries short
227c454 
Closes #330

Linux packages installs binaries to `/usr/local/bin`
and has names:

```
toxiproxy-server-linux-amd64
toxiproxy-cli-linux-amd64
```

It is not common way and different from previous releases.

Changes the binary destination path to `/usr/bin` and has short binary
names:

```
toxiproxy-server
toxiproxy-cli
```
@miry
Copy link
Contributor

miry commented Oct 4, 2021

@SamMorrowDrums Thank you for the report. It is going be fixed in next release with #331

miry added a commit that referenced this issue Oct 5, 2021
@miry
Keep linux binaries short
3dafc46 
Closes #330

Linux packages installs binaries to `/usr/local/bin`
and has names:

```
toxiproxy-server-linux-amd64
toxiproxy-cli-linux-amd64
```

It is not common way and different from previous releases.

Changes the binary destination path to `/usr/bin` and has short binary
names:

```
toxiproxy-server
toxiproxy-cli
```
@miry miry closed this as completed in #331 Oct 5, 2021
miry added a commit that referenced this issue Oct 5, 2021
@miry
Keep linux binaries short (#331)
2f31679 
Closes #330

Linux packages installs binaries to `/usr/local/bin`
and has names:

```
toxiproxy-server-linux-amd64
toxiproxy-cli-linux-amd64
```

It is not common way and different from previous releases.

Changes the binary destination path to `/usr/bin` and has short binary
names:

```
toxiproxy-server
toxiproxy-cli
```
@miry
Copy link
Contributor

miry commented Oct 17, 2021

@SamMorrowDrums Released a new version with a fix: https://github.com/Shopify/toxiproxy/releases/tag/v2.2.0

@SamMorrowDrums
Copy link
Author

Wonderful, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miry miry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Keep linux binaries names short Shopify/toxiproxy
2 participants
@miry @SamMorrowDrums