-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve server log startup message #358
Conversation
Hi @areveny Thank you for contribution. I have not seen in other application explanation how to use health endpoint. I would avoid write this in the logs. The application should crash if there is some problems. Also I think the second message does not correctly says that server hast started listen for the port. But it was executed just write after the first message. I would keep only one message:
The basic verification that it is working: $ toxiproxy-cli list |
Sounds good, here's the updated output. Do you think this closes the linked issue? Or should the documentation be updated. |
It is fine just to close the linked issue. The endpoint to check if toxiproxy ready is presented in README. |
645a6c6
to
c74b0be
Compare
Thanks. It's now what you suggested. Really appreciate the feedback on a small change, I hope I can make more substantial contributions too. |
@areveny Thank you for the contribution. |
@areveny your changes have been released as part of https://github.com/Shopify/toxiproxy/releases/tag/v2.4.0. Thanks for the contribution. |
Old output
New output
Closes #228