ToxicStub allow to unblocking write to Output #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miry
force-pushed
the
locking-problem
branch
2 times, most recently
from
53a7f78
to
7387396
Compare
miry
force-pushed
the
locking-problem
branch
4 times, most recently
from
960d5fe
to
15eb362
Compare
|
This PR seems to cause incorrect HTTP responses on the curl -v -X DELETE http://localhost:49266/proxies/tc-okJxHciQ:5701/toxics/CUT_CONNECTION_DOWNSTREAM
* Trying 127.0.0.1:49266...
* Connected to localhost (127.0.0.1) port 49266 (#0)
> DELETE /proxies/tc-okJxHciQ:5701/toxics/CUT_CONNECTION_DOWNSTREAM HTTP/1.1
> Host: localhost:49266
> User-Agent: curl/7.81.0
> Accept: */*
>
* Empty reply from server
* Closing connection 0
curl: (52) Empty reply from server |
|
Yep, I am working on correcting timeouts to finish Delete toxic in window of WriteTimeout. |
miry
force-pushed
the
locking-problem
branch
3 times, most recently
from
6f3fdcd
to
6e4fd5f
Compare
miry
requested review from
a team,
frightenedmonkey,
yuseinishiyama and
dabealu
and removed request for
a team
It could happen when Link has no reciever and there is some packets in buffer. It produces deadlock. Dynamic test with latest version of toxiproxy
miry
force-pushed
the
locking-problem
branch
from
6e4fd5f
to
524143c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It could happen when Link has no reciever and there is some packets in buffer.
It produces deadlock.