Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zk wait until StateHasSession #210

Open
wants to merge 1 commit into
base: v18.0.8-shopify-1
Choose a base branch
from
Open

zk wait until StateHasSession #210

wants to merge 1 commit into from

Conversation

shanth96
Copy link

@shanth96 shanth96 commented Feb 7, 2025 •
edited
Loading

@shanth96 shanth96 changed the base branch from v18.0.8-shopify-2 to v18.0.8-shopify-1 February 10, 2025 21:26
@shanth96 shanth96 force-pushed the fix-zk-leader-serves-bug branch from dbfeec1 to b4bf4ad Compare February 10, 2025 22:12
@shanth96 shanth96 marked this pull request as ready for review February 11, 2025 17:30
@shanth96 shanth96 changed the title wait until StateHasSession zk wait until StateHasSession Feb 11, 2025
jgnagy
jgnagy approved these changes Feb 13, 2025
View reviewed changes
Copy link

@jgnagy jgnagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code does what the PR description claims! LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilikeorangutans ilikeorangutans ilikeorangutans approved these changes

@jgnagy jgnagy jgnagy approved these changes

@brendar brendar Awaiting requested review from brendar

Assignees
No one assigned
Labels
Available: nil
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shanth96 @ilikeorangutans @jgnagy