Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MaxAltitudeAngle parameter shows as 360Degrees rather than 90Degrees #38

Closed
Short-bus opened this issue Dec 11, 2023 · 1 comment · Fixed by #46
Closed

MaxAltitudeAngle parameter shows as 360Degrees rather than 90Degrees #38

Short-bus opened this issue Dec 11, 2023 · 1 comment · Fixed by #46
Assignees
@Short-bus
Labels
bug Something isn't working

Comments

@Short-bus
Copy link
Owner

Parameter object is initializing MaxAltitudeAngle from the MinAltitudeAngle parameter by mistake, so it is inheriting the 360Degree maximum value. Altitude cannot exceed 90Degrees. Correct the typo in the Parameter class.
@Short-bus Short-bus added the bug Something isn't working label Dec 11, 2023
@Short-bus Short-bus self-assigned this Dec 11, 2023
@Short-bus
Copy link
Owner Author

Testing version which has the correct initial values and will also correct any existing parameter file.

Short-bus added a commit that referenced this issue Dec 18, 2023
@Short-bus
Fix issues 34,35,37,38,39
abffdd7 
#34 Add parameters for star selection magnitude for star lists.
#35 Check ProjectPath variable is respected globally.
#37 Relax the version cross-check between pilomar.py and code.py programs.
#38 MaxAltitudeAngle parameter shows as 360Degrees rather than 90Degrees.
#39 After building the Hipparcos star catalog, pilomar terminates at target prompt.
@Short-bus Short-bus linked a pull request Dec 30, 2023 that will close this issue
2023 dec issues #46
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Short-bus Short-bus

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

2023 dec issues Short-bus/pilomar
1 participant
@Short-bus