Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent return value of request function #62

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

k-86
Copy link
Contributor

@k-86 k-86 commented Jun 2, 2024

When lspEngine==nvim-lsp && opt.sync==true, the request function in request.ts returns response: {err?: lsp.ResponseError, result: unknown}. Otherwise, it returns response.result: unknown.

By unifying the return value to response.result: unknown, Source.#resolve will work when lspEngine==lspoints.

Note: When lspEngine==vim-lsp, Source.#resolve does not work due to another problem.

@Shougo
Copy link
Owner

Shougo commented Jun 3, 2024

Thanks.

@Shougo Shougo merged commit 79e270f into Shougo:main Jun 3, 2024
2 checks passed
@Shougo
Copy link
Owner

Shougo commented Jun 3, 2024

It does not fix #61 problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants