Proposed addition of a base pre-commit hook using pre-commit framework #290
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm proposing that pre-commit hooks be enabled by the pre-commit framework. I thought we could try it here to work out the agreed general style. Potentially it could be rolled out across the other repos.
I've added explicit commits for each fix introduced by the pre-commit. So if any are deemed not required or problematic they can be reverted in this PR.
There's definitely some opinionated parts to this, and these may not be liked based on personal styles, but they offer the following general benefits:
I've staged some additional lint and formatting pre-commit checks to potentially add later.
To call out a couple of potential issues:
Initially add to this repository for developers to run locally. Then, it can be added to the CI/CD pipeline, to either block PR or release as appropriate.