Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building from a Pipfile or requirements.txt #7

Merged
merged 2 commits into from
Dec 2, 2017

Conversation

henryiii
Copy link
Contributor

Currently, you can't include pylandau in a requirements listing for a virtual environment, like pipenv, since it requires that numpy be pre-installed. This patch should lift that requirement.

@henryiii
Copy link
Contributor Author

Fixed and ready for merging if it looks good. :)

@DavidLP
Copy link
Collaborator

DavidLP commented Nov 30, 2017

Thank you very much. The issue is that if numpy is not installed the setup fails since it is imported too early and If one would install numpy first and then pylandau it works, no? Ok, this is an important enhancement, especially since pip install numpy does actually work nowadays.

@henryiii
Copy link
Contributor Author

Yes, so pip install numpy pylandau fails, while pip install numpy && pip install pylandau works, but in a requirements list or similar the user doesn't always have that luxury.

@DavidLP DavidLP merged commit 3d1c908 into SiLab-Bonn:master Dec 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants