Remove unnecessary autopilot config #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisSchinnerl
requested changes
Nov 22, 2024
peterjan
force-pushed
the
pj/remove-current-period
branch
from
8d3987a to
deb14b7
Compare
ChrisSchinnerl
approved these changes
Nov 25, 2024
This merges into removal of contract sets. Now that the UI is merged I kind of want to merge everything into the base branch and go from there. It's at a point where it's technically good enough to be merged into dev I feel. The small design decisions I made that we potentially want to revert can be done in the base branch. Especially since the UI got merged I want to consolidate into a single branch and play-test the whole feature in a single PR because of the many migrations. |
Base automatically changed from
pj/health-using-usability
to
pj/autopilot-state
November 25, 2024 15:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the current period and the allow redundant IP config.
@ChrisSchinnerl this is where I would draw the line as far as removing contract sets goes, there are outstanding tasks in the issue referenced below but I feel tackling all of those would bloat the feature branch too much
Relates to #1667