Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unlock contract funds when host is offline #1720

Merged
merged 8 commits into from
Dec 5, 2024
Merged

Unlock contract funds when host is offline #1720

merged 8 commits into from
Dec 5, 2024

Conversation

ChrisSchinnerl
Copy link
Member

Fixes #1719

@ChrisSchinnerl ChrisSchinnerl self-assigned this Dec 4, 2024
@ChrisSchinnerl ChrisSchinnerl force-pushed the chris/unlock-contract-funds branch 3 times, most recently from 02ee90f to ebc4db0 Compare December 4, 2024 15:00
@ChrisSchinnerl ChrisSchinnerl force-pushed the chris/unlock-contract-funds branch from eba9840 to 3b78531 Compare December 4, 2024 15:21
@ChrisSchinnerl ChrisSchinnerl marked this pull request as ready for review December 4, 2024 16:26
peterjan
peterjan approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@peterjan peterjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments but overall def. good to go

internal/bus/chainsubscriber.go Show resolved Hide resolved
internal/bus/chainsubscriber.go Outdated Show resolved Hide resolved
internal/bus/chainsubscriber.go Show resolved Hide resolved
stores/sql/chain.go Show resolved Hide resolved
stores/sql/database.go Outdated Show resolved Hide resolved
stores/sql/mysql/chain.go Outdated Show resolved Hide resolved
stores/sql/sqlite/chain.go Outdated Show resolved Hide resolved
@ChrisSchinnerl ChrisSchinnerl force-pushed the chris/unlock-contract-funds branch from 21bbecd to 7d6b110 Compare December 5, 2024 11:12
@ChrisSchinnerl ChrisSchinnerl merged commit 9f5b06f into its-happening Dec 5, 2024
12 of 16 checks passed
@ChrisSchinnerl ChrisSchinnerl deleted the chris/unlock-contract-funds branch December 5, 2024 11:24
@peterjan peterjan mentioned this pull request Dec 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterjan peterjan peterjan approved these changes

@n8maninger n8maninger Awaiting requested review from n8maninger

Assignees

@ChrisSchinnerl ChrisSchinnerl

Labels
None yet
Projects
Sia
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrisSchinnerl @peterjan