Add openapi.yml file with autopilot routes #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisSchinnerl
force-pushed
the
chris/openapi
branch
from
7837cc5 to
6cdc256
Compare
ChrisSchinnerl
force-pushed
the
chris/openapi
branch
from
6cdc256 to
12b08d2
Compare
ChrisSchinnerl
changed the title
ChrisSchinnerl
commented
Dec 6, 2024
| @@ -104,11 +104,11 @@ type ( | |||
|
|
|||
| // MinPriceTableValidity is the minimum accepted value for `Validity` in the | |||
| // host's price settings. | |||
| MinPriceTableValidity time.Duration `json:"minPriceTableValidity"` | |||
| MinPriceTableValidity DurationMS `json:"minPriceTableValidity"` | |||
There was a problem hiding this comment.
Nice side effect of the tedious work of writing this specification is that you really don't miss any type. Found 2 fields that we still haven't changed to our MS type.
peterjan
reviewed
Dec 9, 2024
peterjan
approved these changes
Dec 9, 2024
Co-authored-by: Peter-Jan Brone <peterjan.brone@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an openapi.yml spec with the specifications for the autopilot routes and a CI step to validate it. The goal is to eventually have a complete spec for the V2 API that we can use to generate API docs as well as making sure that there is always a valid spec for every given commit in the repo.