Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limiting maximum elevation difference to protect from spikes #49

Merged
merged 4 commits into from
Feb 5, 2021

Conversation

ptrupek
Copy link
Contributor

@ptrupek ptrupek commented Feb 4, 2021

Due to some inaccurate elevation gain/loss data I found there's a plenty of GPX files from mobiles/watches with spikes in elevation (usually 100m> change).
This small adjustment checks if elevation delta is greater then allowed value in phpGPX::$ELEVATION_SMOOTHING_SPIKES_THRESHOLD to avoid spikes.

Check max $ELEVATION_SMOOTHING_SPIKES_THRESHOLD to calculate elevation gain/loss
@Sibyx
Copy link
Owner

Sibyx commented Feb 4, 2021

Hi @ptrupek, first of all, thank you very much for your contribution. Please check travis log (there was a code style issue), we use php-cs-fixer to fix that (configuration is already present in repository). Also, please add description for your feature in the README.md file (configuration section).

I you have any questions, feel free to ask.

@Sibyx Sibyx added the feature label Feb 4, 2021
@ptrupek
Copy link
Contributor Author

ptrupek commented Feb 5, 2021

I've formatted the code according to the code style, but there's nightly build in the travis, which is now PHP8 and is not compatible with phpunit/phpunit ^6.5

@Sibyx
Copy link
Owner

Sibyx commented Feb 5, 2021

Yeah, I see (phpunit is already upgraded on develop branch), I don't want to mess around with php version on master (yet). 1.1.0 will be released (with your feature).

@Sibyx Sibyx merged commit ee0873d into Sibyx:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants