- Bug fix when setting cache directory

- Made property IsChromiumRunning public
Sicos1977 · Oct 16, 2023 · 76f8fd7 · 76f8fd7
1 parent eb8e78f
commit 76f8fd7
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 8 deletions.
diff --git a/ChromiumHtmlToPdfConsole/Properties/launchSettings.json b/ChromiumHtmlToPdfConsole/Properties/launchSettings.json
@@ -2,7 +2,7 @@
   "profiles": {
     "ChromeHtmlToPdf": {
       "commandName": "Project",
-      "commandLineArgs": "--input \"d:\\test.html\" --output d:\\test.pdf  --log-network-traffic --media-load-timeout 15000 --image-resize true --image-load-timeout 15000 --paper-format A4 --sanitize-html"
+      "commandLineArgs": "--input \"d:\\test.html\" --output d:\\test.pdf  --log-network-traffic --media-load-timeout 15000 --image-resize true --image-load-timeout 15000 --paper-format A4 --sanitize-html --disk-cache-directory \"d:\\kees\""
     }
   }
 }
diff --git a/ChromiumHtmlToPdfLib/Converter.cs b/ChromiumHtmlToPdfLib/Converter.cs
@@ -225,7 +225,7 @@ private string BrowserName
     }
 
     /// <summary>
-    ///     Returns the Chromium based browser process id or <c>null</c> when the browser is not running
+    ///     Returns the Chromium based browser process id or <c>null</c> when the browser is not running (anymore)
     /// </summary>
     public int? ChromiumProcessId
     {
@@ -242,7 +242,7 @@ public int? ChromiumProcessId
     ///     Returns <c>true</c> when the Chromium based browser is running
     /// </summary>
     /// <returns></returns>
-    private bool IsChromiumRunning
+    public bool IsChromiumRunning
     {
         get
         {
@@ -493,10 +493,13 @@ private DirectoryInfo GetCacheDirectory
             if (!CurrentTempDirectory.Exists)
                 CurrentTempDirectory.Create();
 
-            return CurrentTempDirectory;
+            return CurrentCacheDirectory;
         }
     }
 
+    /// <summary>
+    ///     <see cref="DocumentHelper"/>
+    /// </summary>
     private DocumentHelper GetDocumentHelper
     {
         get

diff --git a/ChromiumHtmlToPdfLib/Helpers/DocumentHelper.cs b/ChromiumHtmlToPdfLib/Helpers/DocumentHelper.cs
@@ -192,11 +192,7 @@ public DocumentHelper(
     {
         _tempDirectory = tempDirectory;
         _useCache = useCache;
-#if (DEBUG)
-        _cacheDirectory = new DirectoryInfo("d:\\");
-#else
         _cacheDirectory = cacheDirectory;
-#endif
         _cacheSize = cacheSize;
         _webProxy = webProxy;
         _instanceId = instanceId;