Skip to content

Commit

Permalink
Fix some warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
Kees van Spelde committed Mar 12, 2024
1 parent 6bf209f commit 7b37520
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions ChromiumHtmlToPdfConsole/Program.cs
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ public static void Main(string[] args)

#region ParseCommandlineParameters
/// <summary>
/// Parses the commandline parameters and returns these as an <paramref name="options"/>object
/// Parses the commandline parameters and returns these as a <paramref name="options"/>object
/// </summary>
/// <param name="args"></param>
/// <param name="options"><see cref="Options"/></param>
Expand Down Expand Up @@ -280,9 +280,7 @@ private static void SetConverterSettings(Converter converter, Options options)
converter.SetProxyServer(options.ProxyServer);

if (!string.IsNullOrWhiteSpace(options.ProxyByPassList))
{
converter.SetProxyBypassList(options.ProxyByPassList);
}
}

if (!string.IsNullOrWhiteSpace(options.ProxyPacUrl))
Expand Down Expand Up @@ -396,8 +394,10 @@ private static ConvertUri CheckInput(Options options)
/// This function is started from a <see cref="Task"/> and processes <see cref="ConversionItem"/>'s
/// that are in the <paramref name="itemsToConvert"/> queue
/// </summary>
/// <param name="itemsConverted"></param>
/// <param name="options"></param>
/// <param name="instanceId"></param>
/// <param name="itemsToConvert"></param>
private static async Task ConvertWithTask(ConcurrentQueue<ConversionItem> itemsToConvert, ConcurrentQueue<ConversionItem> itemsConverted, Options options, string? instanceId)
{
var pageSettings = GetPageSettings(options);
Expand All @@ -408,10 +408,8 @@ private static async Task ConvertWithTask(ConcurrentQueue<ConversionItem> itemsT

using (logger)
{
await using var converter = new Converter(options.ChromiumLocation, options.ChromiumUserProfile, logger)
{
InstanceId = instanceId
};
await using var converter = new Converter(options.ChromiumLocation, options.ChromiumUserProfile, logger);
converter.InstanceId = instanceId;

SetConverterSettings(converter, options);

Expand Down

0 comments on commit 7b37520

Please sign in to comment.