IDisposable pattern is not needed anymore on the class

Sicos1977 · Oct 17, 2023 · ad495ef · ad495ef
1 parent 604976a
commit ad495ef
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/ChromiumHtmlToPdfLib/Converter.cs b/ChromiumHtmlToPdfLib/Converter.cs
@@ -2620,7 +2620,6 @@ private async Task InternalDisposeAsync()
         if (_disposed)
             return;
 
-        _documentHelper?.Dispose();
         _chromiumWaitEvent?.Dispose();
 
         if (_browser != null)

diff --git a/ChromiumHtmlToPdfLib/Helpers/DocumentHelper.cs b/ChromiumHtmlToPdfLib/Helpers/DocumentHelper.cs
@@ -57,7 +57,7 @@ namespace ChromiumHtmlToPdfLib.Helpers;
 /// <summary>
 ///     This class contains helper methods
 /// </summary>
-internal class DocumentHelper : IDisposable
+internal class DocumentHelper
 {
     #region Fields
     /// <summary>
@@ -205,6 +205,12 @@ public DocumentHelper(
         _imageLoadTimeout = imageLoadTimeout.Value;
         WriteToLog($"Setting image load timeout to '{_imageLoadTimeout}' milliseconds");
     }
+
+    ~DocumentHelper()
+    {
+        // Just in case
+        _stopwatch?.Stop();
+    }
     #endregion
 
     #region ParseValue
@@ -992,11 +998,4 @@ internal void WriteToLog(string message)
         }
     }
     #endregion
-
-    #region Dispose
-    public void Dispose()
-    {
-        _stopwatch?.Stop();
-    }
-    #endregion
 }