-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify key binding ways for compation with vim-which-key #112
Comments
Hello @Mayrixon! Thanks for the positive message and feedback! One interesting thing I'm seeing is that both these mapping scripts live in the I don't see any specific code in vim-which-key to enable/register filetype plugin mappings so I doubt it will be possible to add support for it in mkdx due to it being a filetype plugin rather than a global one. Alternatively, if there was a way to programmatically add filetype specific mappings I think I could implement support for it in mkdx, but that would require the author(s) of vim-which-key to support this scenario. That said I could have missed something as well, do you have an example of a filetype plugin that works with vim-which-key? |
Thanks for the quick reply! There is no specific command in vim-which-key to enable filetype plugin mappings, but we can do this kind of work with I didn't notice the mapping script locations. Luckily, I found vimtex is using scripts in folder As I mentioned, I'm using vim-which-key to manage shortcuts. In my |
I see, it doesn't seem too different from mkdx actually. The actual "mapping" is created via a function instead of directly inside a I'll try adding this plugin to my vimrc to see if I can make it work, though I'm not sure whether it'd be done this week, I'll keep you posted! |
…y skip mapping when exact mappings are found (#112)
@Mayrixon I think my previous commit fixes the issue. I used the I am now using I tested it using: let mapleader = ' '
nnoremap <leader> :<C-U>WhichKey '<Space>'<Cr> " didn't use <silent> in order to allow debug / error messages and this was the result in a markdown buffer: It's pushed to master as it is a reasonably safe change to make, can you verify things are working as expected on your end, or whether more issues pop up? And of course, cheers so far with the feedback, always appreciated! |
I have tested with my settings and everything works perfectly. Thanks for your help! |
No problem, cheers for the quick test and enjoy :) |
Modify key binding ways for competition with vim-which-key
Hello, thanks for the efforts on providing this fantastic plugin. I love some shortcuts provided, such as the one can convert CSVs to tables.
However, I found this plugin cannot work with vim-which-key, a plugin aiming to help people remember shortcuts. I am using <space> as the leader key, but mkdx cannot be activated when I map the prefix to <leader> or <space> with vim-which-key.
I have tested map mkdx's prefix to , or even ,, and these shortcuts can works properly.
I am also using NERD commenter and easymotion. These two plugins can both work with vim-which-key but in different cases. NERD commenter's shortcuts can be recognised by vim-which-key automatically, but easymotion's shortcuts cannot be displayed while works properly. For your convenience, NERD commenter's key bindings can be found here, and easymotion's key bindings could be found here.
The text was updated successfully, but these errors were encountered: