fix import from hash dialog #145
Conversation
| @@ -20,7 +20,8 @@ class Form extends React.Component { | |||
| if (isValid) { | |||
| this.props.statsStore.hash = hash | |||
| this.props.statsStore.isValid = isValid | |||
| this.forceUpdate() | |||
| this.props.statsStore.check() | |||
| .then(() => { this.forceUpdate() }) | |||
There was a problem hiding this comment.
Should we add a catch here?
There was a problem hiding this comment.
The catch is in the stats store, shows an error dialog
| .then(stats => { | ||
| console.log('got stats') | ||
| this.stats = stats | ||
| this.isLoading = false |
There was a problem hiding this comment.
What about concurrency?
Should we have a isLoading both here and on line 46, or should we have a .then right after the Promise.all? What are the pro/cons of this?
There was a problem hiding this comment.
I agree, better to handle them in Promise.all
|
The behaviour now is a little bit slower: The "find peers" is a little bit slower than the one that is fetching the size. Before it was loading them asynchronously, now instead we have to wait for both of them to be ready before showing the value. What do you think of this change? |
|
Hmm, I'll make them resolve async, getting the peers takes way too long |
This reverts commit 9088022.
|
I've reverted the last commit, now they should resolve async, there no concurrency problem though, when one resolves before the other, the other will show |
What changed?
It turns out the peers do load eventually (it's just very slow), but while testing the dialog I found out some other bug: If you change the hash, it no longer tries to get the peers and size, so I move the whole method in the store and called it after the text changed and is valid.
This fixes: https://gitlab.com/siderus/Orion/issues/2