Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 81: Added getFirstItem method #198

Merged
merged 3 commits into from
Nov 10, 2021

Conversation

maryiabydanova
Copy link
Contributor

@maryiabydanova maryiabydanova commented Nov 10, 2021

resolves #81

Question:
not quite sure what readme sample is referenced in the todo. Where would be the best place to add a usage sample?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Siemienik Siemienik self-requested a review November 10, 2021 06:23
@Siemienik
Copy link
Owner

@maryiabydanova Thank you for your contribution 🥇

not quite sure what readme sample is referenced in the todo. Where would be the best place to add a usage sample?

Actually, recently I moved documentation from repo to the website https://siemienik.com/ .
For these changes, I suggest https://github.com/Siemienik/siemienik.github.io/blob/master/docs/xlsx-import-readme.md .

@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #198 (a5b7688) into master (f2502d6) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #198   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           55        55           
  Lines         1078      1087    +9     
  Branches       154       154           
=========================================
+ Hits          1078      1087    +9     
Flag Coverage Δ
xlsx-import 100.00% <100.00%> (ø)
xlsx-renderer 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/xlsx-import/src/Importer.ts 100.00% <100.00%> (ø)
...sx-import/tests/integration/vertical-lists.test.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2502d6...a5b7688. Read the comment docs.

Copy link
Owner

@Siemienik Siemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @maryiabydanova! You did it perfectly 🥇

@Siemienik Siemienik merged commit 70a98b7 into Siemienik:master Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Import.getFirst(cfg) function
2 participants