Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Mappers): add booleanMapper into mappers #54

Merged
merged 9 commits into from
Oct 19, 2020
Merged

feat(Mappers): add booleanMapper into mappers #54

merged 9 commits into from
Oct 19, 2020

Conversation

machadolucasvp
Copy link
Contributor

@machadolucasvp machadolucasvp commented Oct 18, 2020 •
edited
Loading

#53
When accepted, if so, can please label this PR with hacktoberfest-accepted 😄 ?

@codecov
Copy link

codecov bot commented Oct 18, 2020 •
edited
Loading

Codecov Report

Merging #54 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #54   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines          366       361    -5     
  Branches         5         5           
=========================================
- Hits           366       361    -5
Impacted Files Coverage Δ
src/mappers/booleanMapper.ts 100.00% <100.00%> (ø)
src/mappers/index.ts 100.00% <100.00%> (ø)
tests/unit/mappers/booleanMapper.test.ts 100.00% <100.00%> (ø)
tests/unit/mappers/numberMapper.test.ts
src/mappers/numberMapper.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 869141f...036ed5d. Read the comment docs.

@machadolucasvp machadolucasvp marked this pull request as ready for review October 18, 2020 17:36
@machadolucasvp
Copy link
Contributor Author

machadolucasvp commented Oct 18, 2020 •
edited
Loading

@Siemienik what you think about create a utils/helpers folder ? problably removeTextAfterValidNumber will be used in #46 and #48

Siemienik
Siemienik requested changes Oct 19, 2020
View reviewed changes
Copy link
Owner

@Siemienik Siemienik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for great contribution 👍
I have only one comment for you, could I please you to use .parseFloat instead of removeTextAfterValidNumber

src/mappers/booleanMapper.ts Outdated
@@ -0,0 +1,7 @@
import { ValueMapper } from '../abstracts/ValueMapper';

const removeTextAfterValidNumber = (value: string): string | undefined =>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Siemienik what you think about create a utils/helpers folder ? problably removeTextAfterValidNumber will be used in #46 and #48

This util is redundant if you use Number.parseFloat

image

Copy link
Contributor Author

@machadolucasvp machadolucasvp Oct 19, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aah okay, i had no idea that parseFloat already do that under the hood

@Siemienik
Copy link
Owner

When accepted, if so, can please label this PR with hacktoberfest-accepted 😄 ?

It isn't required if I merge PR into master and I will do it soon after resolving: #54 (comment)

Siemienik
Siemienik approved these changes Oct 19, 2020
View reviewed changes
Copy link
Owner

@Siemienik Siemienik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you for a contributions :)

@Siemienik Siemienik merged commit 940337c into Siemienik:master Oct 19, 2020
@Siemienik Siemienik mentioned this pull request Oct 19, 2020
Closed
4 tasks
Siemienik added a commit that referenced this pull request Nov 8, 2020
@Siemienik
Upgrade ExcelJS to 4.2.0 & Upgrade deps (#54)
bf057ec 
* Upgrade deps, Upgrade exceljs to 4+

* Remove supporting for node 8&9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siemienik Siemienik Siemienik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@machadolucasvp @Siemienik