Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: logs parsing pipeline support in opamp #2456

Merged
merged 10 commits into from
Mar 22, 2023
Merged

feat: logs parsing pipeline support in opamp #2456

merged 10 commits into from
Mar 22, 2023

Conversation

nityanandagohain
Copy link
Member

PR for #1779

This PR only adds the logic on how log pipelines will be sent to opamp and how it will be handled by agent conf.

@github-actions github-actions bot added the chore label Mar 15, 2023
@SigNoz SigNoz deleted a comment from github-actions bot Mar 15, 2023
@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@nityanandagohain nityanandagohain mentioned this pull request Mar 15, 2023
Merged
@nityanandagohain nityanandagohain changed the title chore: logs parsing pipeline support in opamp feat: logs parsing pipeline support in opamp Mar 15, 2023
@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

srikanthccv
srikanthccv reviewed Mar 15, 2023
View reviewed changes
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewing the logic part of the buildLogsProcessors at the moment because I am still finding it hard to follow the rest with the loose interfaces{} use for components.

pkg/query-service/app/opamp/logspipeline_test.go Show resolved Hide resolved
@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the enhancement New feature or request label Mar 16, 2023
@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@nityanandagohain
Copy link
Member Author

Have updated the logic and added the new test cases for processor ordering, please have a look again.

@nityanandagohain
Copy link
Member Author

@srikanthccv please have a look at this when you get some time.

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@srikanthccv srikanthccv self-assigned this Mar 20, 2023
@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
6.2% 6.2% Duplication

@nityanandagohain nityanandagohain merged commit 27db1b9 into develop Mar 22, 2023
@nityanandagohain nityanandagohain deleted the feat/opamp-logparing branch March 22, 2023 04:25
@srikanthccv
Copy link
Member

Please squash next time.

@nityanandagohain
Copy link
Member Author

Sure @srikanthccv

@srikanthccv
Copy link
Member

Screenshot 2023-03-22 at 2 14 35 PM

These intermittent commits will appear as fixes for release notes which are actually review fixes and make it difficult to follow the history along with the reverse Merge commits. I believe the default merge option should already be set to Squash and Merge, so you can either use that option or make sure your commits are squashed locally. Either way is fine. But we don't want to let the intermediate fix: show up as the actual fixes in release notes or history.

Screenshot 2023-03-22 at 2 07 08 PM

@nityanandagohain
Copy link
Member Author

Yeah correct, will take care of this from the next PR's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv approved these changes

Assignees

@srikanthccv srikanthccv

Labels
chore codeball:needs-careful-review Codeball enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nityanandagohain @srikanthccv @makeavish