-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ms teams channels #2689
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
@mindhash these code changes looks good to me. Can you resolve the conflicts? |
@srikanthccv Sure. I will be able to get to this by Saturday. |
@srikanthccv @palashgdev resolved merge comments. |
@palashgdev please review the frontend changes again. |
One action item to resolve before merging this is not upselling to OSS users (not to be confused with ee community edition). Just like how the new query builder for logs and traces doesn't appear at all, there shouldn't be any MS Teams options in channels for OSS users. |
Sure @srikanthccv |
This works, I tested it by creating an MS Teams channel and notifications are received. @palashgdev is this point addressed #2689 (comment)? We don't want to UPSELL this to OSS users but should be okay to upsell for basic plan users. |
but here we are already making a prompt to user that this feature is available in paid subscription ![]() but if your intent is not to show this option itself then should we show when let me know your thoughts |
This PR introduces MS teams for enterprise plans.
Linked issue: #1601
Depents on : SigNoz/alertmanager#5