Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ms teams channels #2689

Merged
merged 14 commits into from
Aug 15, 2023
Merged

feat: add ms teams channels #2689

merged 14 commits into from
Aug 15, 2023

Conversation

mindhash
Copy link
Contributor

@mindhash mindhash commented May 14, 2023

This PR introduces MS teams for enterprise plans.

Linked issue: #1601

Depents on : SigNoz/alertmanager#5

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the enhancement New feature or request label May 14, 2023
@mindhash mindhash changed the title Feat/ms teams feat: add ms teams channels May 14, 2023
@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@srikanthccv
Copy link
Member

@mindhash these code changes looks good to me. Can you resolve the conflicts?

@mindhash
Copy link
Contributor Author

mindhash commented Jun 8, 2023

@srikanthccv Sure. I will be able to get to this by Saturday.

@mindhash
Copy link
Contributor Author

@srikanthccv @palashgdev resolved merge comments.

@makeavish makeavish requested a review from palashgdev July 7, 2023 01:28
@srikanthccv
Copy link
Member

@palashgdev please review the frontend changes again.

@srikanthccv
Copy link
Member

One action item to resolve before merging this is not upselling to OSS users (not to be confused with ee community edition). Just like how the new query builder for logs and traces doesn't appear at all, there shouldn't be any MS Teams options in channels for OSS users.

@palashgdev
Copy link
Contributor

@palashgdev please review the frontend changes again.

Sure @srikanthccv

@palashgdev palashgdev self-requested a review August 9, 2023 16:59
palashgdev
palashgdev previously approved these changes Aug 9, 2023
@srikanthccv
Copy link
Member

This works, I tested it by creating an MS Teams channel and notifications are received.

@palashgdev is this point addressed #2689 (comment)? We don't want to UPSELL this to OSS users but should be okay to upsell for basic plan users.
Screenshot 2023-08-14 at 7 50 03 PM

@palashgdev
Copy link
Contributor

This works, I tested it by creating an MS Teams channel and notifications are received.

@palashgdev is this point addressed #2689 (comment)? We don't want to UPSELL this to OSS users but should be okay to upsell for basic plan users. Screenshot 2023-08-14 at 7 50 03 PM

but here we are already making a prompt to user that this feature is available in paid subscription

Screenshot 2023-08-14 at 10 34 10 PM

but if your intent is not to show this option itself then should we show when DISABLE_UPSELL is false ?

let me know your thoughts

@palashgdev palashgdev self-requested a review August 15, 2023 15:48
@palashgdev palashgdev merged commit 2bf534b into develop Aug 15, 2023
@palashgdev palashgdev deleted the feat/ms-teams branch August 15, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codeball:needs-careful-review Codeball enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants