fix: use proper indexes for full text search #4787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srikanthccv
reviewed
Apr 2, 2024
srikanthccv
previously approved these changes
Apr 2, 2024
srikanthccv
reviewed
Jul 1, 2024
srikanthccv
reviewed
Jul 4, 2024
|
One other thing that this PR changes is that it uses like in favour of ilike, which means that attribute queries for contains and like won't be case independent now. I am not sure if we should remove it for this PR. cc @srikanthccv |
|
Yes, that should have a separate issue for itself. |
|
Have made the changes, now it will only apply for body . Attributes and resource attributes won't be touched. |
srikanthccv
reviewed
Jul 22, 2024
srikanthccv
approved these changes
Jul 22, 2024
| @@ -72,6 +73,7 @@ func getPath(keyArr []string) string { | |||
|
|
|||
| func getJSONFilterKey(key v3.AttributeKey, op v3.FilterOperator, isArray bool) (string, error) { | |||
| keyArr := strings.Split(key.Key, ".") | |||
| // i.e it should be at least body.name, and not something like body | |||
| if len(keyArr) < 2 { | |||
There was a problem hiding this comment.
does this account for body. where there is just space after the . ?
There was a problem hiding this comment.
keys dont contain space, it will be a invalid query
There was a problem hiding this comment.
it will be returned before reaching this point ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4259
changes
attributes search with operatorcontainswill also uselower(attribute)now but there is no change for them.