Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added the host detail view #6267

Merged
merged 2 commits into from
Nov 6, 2024
Merged

feat: added the host detail view #6267

merged 2 commits into from
Nov 6, 2024

Conversation

rahulkeswani101
Copy link
Contributor

@rahulkeswani101 rahulkeswani101 commented Oct 25, 2024

Summary

  • Added the Host Detailed view which will open on click of the host list records.
  • Added tabs and initial details for hosts detailed view.

Related Issues / PR's

https://github.com/SigNoz/engineering-pod/issues/1878

Screenshots

image

Affected Areas and Manually Tested Areas

  • Tested the initial flow and on click of record the proper details are populated.
  • Data is consistent on the drawer and closing the drawer is functioning as expected.
  • Host name can be empty so, I need to handle this scenario while filtering the data. I will handle this in a separate PR.

Important

Add HostMetricDetail component for detailed host metrics view with integrated styles and functionality in the host list.

  • New Feature:
    • Added HostMetricDetail component in index.tsx for detailed host metrics view.
    • Introduced HostDetailProps type in HostMetricDetail.interfaces.ts for component props.
    • Added VIEWS enum and VIEW_TYPES constant in constants.ts for view management.
  • Styles:
    • Created HostMetricsDetail.styles.scss for styling the host detail drawer and its elements.
    • Updated InfraMonitoring.styles.scss to include styles for clickable rows.
  • Integration:
    • Integrated HostMetricDetail in HostsList.tsx to open on row click and close on drawer close.
    • Modified utils.tsx to rename ioWait to wait in HostRowData and update related logic.

This description was created by Ellipsis for e2db119. It will automatically update as commits are pushed.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the enhancement New feature or request label Oct 25, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to e3fdf42 in 40 seconds

More details
  • Looked at 492 lines of code in 7 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. frontend/src/pages/InfraMonitoringHosts/utils.tsx:16
  • Draft comment:
    The 'wait' field in the HostRowData interface was previously named 'ioWait'. Ensure that all references to 'ioWait' are updated to 'wait' to maintain consistency.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. frontend/src/pages/InfraMonitoringHosts/utils.tsx:119
  • Draft comment:
    The 'dataIndex' for the 'IOWait' column should be updated to 'wait' to match the updated field name in the HostRowData interface.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_3LYWU6Nf73p0Wik5


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

github-actions bot commented Nov 5, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@ahmadshaheer
Copy link
Collaborator

A few observations, @rahulkeswani101

image

  1. the status is not visible

  2. can we change the UI of status and operating system to badge?
    image

  3. the CPU and Memory usage progress bars are not reflecting the percentage

  4. Can we only show the tabs that have data? / alternatively, can we show empty state?

@ahmadshaheer
Copy link
Collaborator

A few observations, @rahulkeswani101

image

  1. the status is not visible
  2. can we change the UI of status and operating system to badge?
    image
  3. the CPU and Memory usage progress bars are not reflecting the percentage
  4. Can we only show the tabs that have data? / alternatively, can we show empty state?

@rahulkeswani101

Please ignore the 1, 2, and 3 points. I just noticed that they are fixed in #6297

Copy link

github-actions bot commented Nov 6, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@rahulkeswani101 rahulkeswani101 merged commit 1af121d into host-lists Nov 6, 2024
7 of 8 checks passed
YounixM added a commit that referenced this pull request Nov 21, 2024
* feat: added the host list view and filters

* feat: removed group by filter and added autocomplete for where clause

* feat: updated the table view and added the pagination

* feat: pass updated filters to api to get filtered data in the list

* feat: added global time range and order by for cpu,memory,iowait,load

* feat: added order by and color codes for cpu and memory usage progress bar

* refactor: removed inline styles

* Host lists improvement (#6366)

* style: added new style changes for date time selection in host lists view

* style: added padding to date time selector

* style: removed unnecessary styles for host tabs

* style: removed unused css

* feat: added the host detail view (#6267)

* Host containers (#6297)

* feat: added the host detail view

* feat: completed containers and processes details view

* Show host metrics panels in metrics tab. (#6306)

* feat: added the host detail view

* feat: completed containers and processes details view

* feat: added host metrics panels in metrics tabs

* refactor: removed inline styles from host containers and processes tabs

* style: added top and bottom margin to containers and processes tab

* Metrics time selection (#6360)

* feat: added the host detail view

* feat: completed containers and processes details view

* feat: added host metrics panels in metrics tabs

* refactor: removed inline styles from host containers and processes tabs

* feat: added logs and traces tab in host metrics detail view

* chore: removed console statements

* feat: added DateTimeSelection component in metrics tab

* style: added top and bottom margin to containers and processes tab

* style: removed inline styles

* feat: added logs and traces tab in host metrics detail view (#6359)

* feat: added the host detail view

* feat: completed containers and processes details view

* feat: added host metrics panels in metrics tabs

* refactor: removed inline styles from host containers and processes tabs

* feat: added logs and traces tab in host metrics detail view

* chore: removed console statements

* feat: added filters and time selection in traces tab

* fix: resolved metrics,logs and traces tab issues

* feat: added navigation for logs and traces to respective explorer pages

* fix: added the code for logs tab and navigation to respective explorer page

* fix: added fixes for date time selection custom issue

* style: added styles for light mode

* refactor: removed unused code and added comments

* refactor: added new code for host metric attribute keys

* feat: reset query data once we are on infra monitoring page

* chore: remove optional parameter from get attributes and groupby interfaces

* feat: update ui as per the designs

* fix: logs list, time select and other ui issues

* feat: update title for infra monitoring page

* feat: update copies

* feat: update styles for light mode

* fix: reset page size on filter, open explorers in new tab, enable horizontal scroll

* feat: traces tab updates

* feat: move infra monitoring behind ff

* fix: remove sorting from host listing page

---------

Co-authored-by: Yunus M <myounis.ar@live.com>
YounixM added a commit that referenced this pull request Nov 21, 2024
* feat: added the host list view and filters (#6210)

* feat: added the host list view and filters

* feat: removed group by filter and added autocomplete for where clause

* feat: updated the table view and added the pagination

* feat: pass updated filters to api to get filtered data in the list

* feat: added global time range and order by for cpu,memory,iowait,load

* feat: added order by and color codes for cpu and memory usage progress bar

* refactor: removed inline styles

* Host lists improvement (#6366)

* style: added new style changes for date time selection in host lists view

* style: added padding to date time selector

* style: removed unnecessary styles for host tabs

* style: removed unused css

* feat: added the host detail view (#6267)

* Host containers (#6297)

* feat: added the host detail view

* feat: completed containers and processes details view

* Show host metrics panels in metrics tab. (#6306)

* feat: added the host detail view

* feat: completed containers and processes details view

* feat: added host metrics panels in metrics tabs

* refactor: removed inline styles from host containers and processes tabs

* style: added top and bottom margin to containers and processes tab

* Metrics time selection (#6360)

* feat: added the host detail view

* feat: completed containers and processes details view

* feat: added host metrics panels in metrics tabs

* refactor: removed inline styles from host containers and processes tabs

* feat: added logs and traces tab in host metrics detail view

* chore: removed console statements

* feat: added DateTimeSelection component in metrics tab

* style: added top and bottom margin to containers and processes tab

* style: removed inline styles

* feat: added logs and traces tab in host metrics detail view (#6359)

* feat: added the host detail view

* feat: completed containers and processes details view

* feat: added host metrics panels in metrics tabs

* refactor: removed inline styles from host containers and processes tabs

* feat: added logs and traces tab in host metrics detail view

* chore: removed console statements

* feat: added filters and time selection in traces tab

* fix: resolved metrics,logs and traces tab issues

* feat: added navigation for logs and traces to respective explorer pages

* fix: added the code for logs tab and navigation to respective explorer page

* fix: added fixes for date time selection custom issue

* style: added styles for light mode

* refactor: removed unused code and added comments

* refactor: added new code for host metric attribute keys

* feat: reset query data once we are on infra monitoring page

* chore: remove optional parameter from get attributes and groupby interfaces

* feat: update ui as per the designs

* fix: logs list, time select and other ui issues

* feat: update title for infra monitoring page

* feat: update copies

* feat: update styles for light mode

* fix: reset page size on filter, open explorers in new tab, enable horizontal scroll

* feat: traces tab updates

* feat: move infra monitoring behind ff

* fix: remove sorting from host listing page

---------

Co-authored-by: Yunus M <myounis.ar@live.com>

* chore: fix lint errors

---------

Co-authored-by: rahulkeswani101 <rahul@signoz.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants