Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add user email to log_comment #6461

Merged
merged 1 commit into from
Nov 16, 2024
Merged

chore: add user email to log_comment #6461

merged 1 commit into from
Nov 16, 2024

Conversation

srikanthccv
Copy link
Member

@srikanthccv srikanthccv commented Nov 16, 2024

Summary

Fixes #6439


Important

Adds user email to log comments in LogCommentEnricher by extracting it from JWT in server.go.

  • Behavior:
    • Adds user email to log comments in LogCommentEnricher in server.go by extracting email from JWT.
    • Logs an error if email extraction from JWT fails.
  • Misc:
    • No changes to existing functionality, only enhancement to logging.

This description was created by Ellipsis for 441f833. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 441f833 in 39 seconds

More details
  • Looked at 24 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. pkg/query-service/app/server.go:384
  • Draft comment:
    Avoid using the component/index.tsx file structure approach, as it makes it difficult to debug and find components using global search tools like VS Code.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    The comment is not related to the changes made in the diff. The diff is about Go server code, specifically adding email extraction from JWT, and has nothing to do with React component structure. The comment should be removed as it is not relevant to the changes.
    I might be missing some context about the overall project structure, but based on the provided diff, the comment is not relevant.
    The diff is clearly about Go server code, and there is no indication of any React component structure changes. The comment is not applicable here.
    Remove the comment as it is not relevant to the changes made in the diff.

Workflow ID: wflow_C2UyAlvfFtiaOMaL


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

pkg/query-service/app/server.go Show resolved Hide resolved
@srikanthccv srikanthccv merged commit 493ae4f into develop Nov 16, 2024
16 checks passed
@srikanthccv srikanthccv deleted the add-email branch November 16, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add user email to log_commnt query
2 participants