-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add Chinese Traditional documentation and comparisons #6482
base: main
Are you sure you want to change the base?
Conversation
- Update README.md to include links to both Chinese Traditional and Chinese Simplified versions - Add a new README.zh-tw.md file with comprehensive documentation in Chinese Traditional, covering features like application performance monitoring, log management, distributed tracing, metrics and dashboards, alerts, and exception monitoring - Include comparisons of SigNoz with other tools like Prometheus, Jaeger, Elastic, and Loki in the README.zh-tw.md file - Provide instructions for getting started with SigNoz, including creating a cloud account, self-hosted deployment using Docker, and Kubernetes deployment using Helm - Highlight the benefits of choosing SigNoz and supported programming languages for instrumentation in the README.zh-tw.md file - Add information about contributing to the project, project maintainers, and community engagement in the README.zh-tw.md file Signed-off-by: appleboy <appleboy.tw@gmail.com>
Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 3d63e67 in 28 seconds
More details
- Looked at
274
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. README.md:20
- Draft comment:
Consider renaming "ReadMe in Chinese Traditional" to "README in Chinese Traditional" for consistency with other language links. - Reason this comment was not posted:
Confidence changes required:10%
The PR adds a new README in Chinese Traditional, which is a good addition for localization. However, there is a minor inconsistency in the naming of the Chinese Simplified README link in the main README file. It should be consistent with the naming convention used for other languages.
Workflow ID: wflow_4AEDaAClnhv4jAr8
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
- Update links in Chinese README to include English and Traditional Chinese README links - Update links in Traditional Chinese README to include English and Simplified Chinese README links Signed-off-by: appleboy <appleboy.tw@gmail.com>
Summary
Related Issues / PR's
Screenshots
NA
Affected Areas and Manually Tested Areas
Important
Add Chinese Traditional documentation in
README.zh-tw.md
and updateREADME.md
with links to Chinese versions.README.zh-tw.md
with comprehensive Chinese Traditional documentation.README.md
to include links to Chinese Traditional and Chinese Simplified versions.README.zh-tw.md
covers features like application performance monitoring, log management, distributed tracing, metrics and dashboards, alerts, and exception monitoring.This description was created by for 3d63e67. It will automatically update as commits are pushed.