-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: decrease the pad angle and remove the empty legend entries #6507
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 60c72e5 in 13 seconds
More details
- Looked at
41
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. frontend/src/container/PanelWrapper/PiePanelWrapper.tsx:11
- Draft comment:
The import ofisNaN
fromlodash-es
is unnecessary. Consider using the built-inisNaN
function instead to reduce bundle size. - Reason this comment was not posted:
Confidence changes required:50%
The import ofisNaN
fromlodash-es
is unnecessary sinceisNaN
is a built-in JavaScript function. Using the built-in function can reduce bundle size and improve performance slightly.
2. frontend/src/container/PanelWrapper/PiePanelWrapper.tsx:113
- Draft comment:
Avoid using inline styles. Consider using CSS classes or styled components instead. This is applicable in multiple places, such as lines 182-186 and 190-192. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_HKMzZ3IzkpR2Nh18
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
contributes to - https://github.com/SigNoz/engineering-pod/issues/2026 |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Summary
padAngle
adds a padding between adjacent values which appears as a chunk on pie chart.0
entries also present they were consuming the padding still. removed the 0 entries.Related Issues / PR's
Screenshots
Affected Areas and Manually Tested Areas