feat: added API limiting to reduce unnecessary api call for dashboard variables

[SagarRajput-7]

Summary

Related Issues / PR's

Screenshots

NA

Affected Areas and Manually Tested Areas

---

Important

Adds dependency management and API call optimization for dashboard variables in DashboardVariableSelection and VariableItem.

• Dependency Management:
  • Added buildDependencies, buildDependencyGraph, buildParentDependencyGraph, and onUpdateVariableNode in util.ts to manage variable dependencies.
  • DashboardVariableSelection.tsx initializes and updates dependencyData using these functions.
• Variable Update Logic:
  • Modified onValueUpdate in DashboardVariableSelection.tsx to handle variable dependencies when updating values.
  • VariableItem.tsx uses validVariableUpdate to determine if a variable update is valid based on dependencies.
• API Invocation Optimization:
  • Introduced checkAPIInvocation in util.ts to optimize when API calls are made based on variable dependencies.
  • VariableItem.tsx uses this function to conditionally enable API queries.

^{This description was created by for 421d355. It will automatically update as commits are pushed.}

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[ellipsis-dev]

👍 Looks good to me! Incremental review on 421d355 in 35 seconds

More details

• Looked at 174 lines of code in 3 files
• Skipped 0 files when reviewing.
• Skipped posting 4 drafted comments based on config settings.

1. frontend/src/container/NewDashboard/DashboardVariablesSelection/util.ts:4

• Draft comment:
  Consider enhancing areArraysEqual to handle nested arrays or objects, if applicable, to ensure accurate comparisons.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The function areArraysEqual is used multiple times across the codebase to compare arrays. However, it does not account for cases where the arrays might contain objects or nested arrays. This could lead to incorrect comparisons if such cases arise.

2. frontend/src/container/NewDashboard/DashboardVariablesSelection/util.ts:171

• Draft comment:
  The check for isEmpty(parentDependencyGraph) is redundant as it is already performed at the start of the function. Consider removing it to simplify the code.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The checkAPIInvocation function has a redundant check for parentDependencyGraph being empty. This check is already performed at the beginning of the function, making the second check unnecessary.

3. frontend/src/container/NewDashboard/DashboardVariablesSelection/VariableItem.tsx:224

• Draft comment:
  Ensure that checkAPIInvocation is correctly determining when API calls should be made, as it is crucial for performance optimization.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The checkAPIInvocation function is used in multiple places, and its logic is crucial for determining when API calls should be made. Ensuring its correctness and efficiency is important for performance.

4. frontend/src/container/NewDashboard/DashboardVariablesSelection/VariableItem.tsx:218

• Draft comment:
  Use design tokens or predefined color constants instead of hardcoding color values. This is also applicable in other parts of the code where colors are hardcoded.
• Reason this comment was not posted:
  Comment was not on a valid diff hunk.

Workflow ID: wflow_FSbDXRI0JFo5mjpl

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.