Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: changed droprate view options values #6693

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SagarRajput-7
Copy link
Contributor

@SagarRajput-7 SagarRajput-7 commented Dec 21, 2024

Summary

Changed drop rate options from - 1ms, 2ms, 5ms, 10ms, 15ms to 10ms, 20ms, 50ms, 100ms, 150ms, 200ms, 500ms

Related Issues / PR's

Screenshots

Before -

image

After:

image
Screen.Recording.2024-12-21.at.12.01.14.PM.mov

Affected Areas and Manually Tested Areas

Tested droprate view dropdown selection and respective API payload and responses


Important

Updated drop rate options and default selection in EvaluationTimeSelector.tsx.

  • Behavior:
    • Updated drop rate options in EvaluationTimeSelector.tsx from 1ms, 2ms, 5ms, 10ms, 15ms to 10ms, 20ms, 50ms, 100ms, 150ms, 200ms, 500ms.
    • Changed default selected interval from 5ms to 10ms in EvaluationTimeSelector.tsx.

This description was created by Ellipsis for 806d944. It will automatically update as commits are pushed.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 806d944 in 12 seconds

More details
  • Looked at 33 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. frontend/src/pages/MessagingQueues/MQDetails/DropRateView/EvaluationTimeSelector.tsx:45
  • Draft comment:
    The initial value of selectedInterval was changed from '5ms' to '10ms', which aligns with the new options. This is a correct change.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The initial value of selectedInterval was changed from '5ms' to '10ms', which aligns with the new options. This is a correct change.
2. frontend/src/pages/MessagingQueues/MQDetails/DropRateView/EvaluationTimeSelector.tsx:100
  • Draft comment:
    Avoid using inline styles. Use external stylesheets, CSS classes, or styled components instead.
  • Reason this comment was not posted:
    Comment was not on a valid diff hunk.

Workflow ID: wflow_Y2QJx9CkkTNLggdS


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant