chore(deps): update cespare/xxhash to v2 version
#6714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juneezee
changed the title
cespare/xxhash to v2 versioncespare/xxhash to v2 version
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 1a2801a in 20 seconds
More details
- Looked at
68lines of code in3files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. pkg/query-service/utils/labels/labels.go:10
- Draft comment:
Ensure that the usage ofxxhashfunctions is compatible with the v2 version. The import path has been updated correctly, but verify that the function calls (e.g.,xxhash.Sum64) are still valid and behave as expected. - Reason this comment was not posted:
Confidence changes required:50%
The PR updates the import path for the xxhash package to v2, which is correct. However, the PR description mentions that there are no breaking changes, but it's always good to verify if the usage of the package in the code is compatible with the new version.
2. pkg/query-service/utils/labels/labels.go:10
- Draft comment:
Ensure that thexxhashpackage is used only for hashing purposes related to ClickHouse. If there are non-ClickHouse related functions, consider using the DAO in the telemetry instance instead. - Reason this comment was not posted:
Confidence changes required:50%
The code uses the xxhash package correctly, and there are no violations of the rules provided.
Workflow ID: wflow_da7Y8IPQzub5VCOG
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
`github.com/cespare/xxhash/v2` is the latest version with bug fixes and improvements. Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Juneezee
changed the title
cespare/xxhash to v2 versioncespare/xxhash to v2 version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
github.com/cespare/xxhash/v2is the latest version with bug fixes and improvements.No breaking changes. See https://go.dev/play/p/q35yQ6UUE5A
Related Issues / PR's
Screenshots
NA
Affected Areas and Manually Tested Areas
Important
Update
cespare/xxhashto version 2.3.0 and adjust import paths accordingly.cespare/xxhashtov2.3.0ingo.mod.cespare/xxhash/v2indirect dependency ingo.mod.go.sumto reflect changes incespare/xxhashversion.github.com/cespare/xxhash/v2inlabels.go.This description was created by
for 1a2801a. It will automatically update as commits are pushed.