-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed poetry install error on Python 3.11(due to pylint dependency) #73
Fixed poetry install error on Python 3.11(due to pylint dependency) #73
Conversation
The full stack trace of the Poetry install error is below.
|
Thanks, that's great! Just didn't came to add Python 3.11, now it's done 👍 Can you add 3.11 to the test matrix here: https://github.com/SigmaHQ/pySigma/blob/main/.github/workflows/test.yml#L14 ? |
Thanks for your quick comment :) I'll add test matrix and also investigate github actions error on win2019! |
I already fixed the Windows error Yesterday by removing rope from the development dependencies. Just rebase to the current main branch or merge it into yours should do it. |
This PR already contained the above fix(removing rope from the devdependencies) ... 🤔 |
I've done a "Rebase&merge", should work 😉 |
Seems to be now a different package that makes problems 😌 And yes, it appears to be restricted to Python 3.9. |
Thank you so much for merging :) If I find out anything about the windows error, I'd like to share. |
I have also tried in Windows 2019 Datacenter edition(on aws) + Python 3.9.13, but poetry install suceeded ... 🤔 |
Thank you for maintaining pySigma :)
I don't know if it supports Python3.11, but I fixed a poetry installation error with Python3.11.
What Changed
tool.poetry.dev-dependencies
version of pylint^2.6.0
to^2.15.7
(Latest version as of today)Motivation and Context
Poetry install fails with python3.11 as follows.
The cause of the above error is this wrapt issue.
I investigated the
wrapt
dependencies.Pylint
depends onastroid
->wrapt
as bellow,so updating
Pylint
to the latest version resolved the issue.Test
I have tested below.
Enviroment
Python versions
I have tested in the three Python versions as below.
Commands
I have confirmed that the commands below are all successful with the above three Python versions.
I would appreciate it if you could review🙏