Update rule condition #4716
Merged
Update rule condition #4716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
last commit removed the c but didn't change the condition from startswith to contains
github-actions
bot
added
Rules
Windows
Event 6416 was not part of selection_usb, that was wrong, because deviceDescription is also the field of 6416.
qasimqlf
changed the title
nasbench
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
1st: Filter condition was still startswith after removing c in last commit but it should also be changed to contains.
2nd: Event 6416 also included deviceDescription, so i updated the event condition
Changelog
update: External Disk Drive Or USB Storage Device Was Recognized By The System - Update selection to reflect the logic correctly
fix: Uncommon Service Installation Image Path - Update filter logic to use correct modifiers
Example Log Event
N/A
Fixed Issues
N/A
SigmaHQ Rule Creation Conventions