Make ESP32AnalogReader work for some ADC2 pins #642
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Sorry, missed the notification email.) Thanks! Looks good to me, but I'll keep it open until I can test it (or someone else verifies it works as intended). |
|
Closing due to no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pins on ADC2 are configured and read differently from the pins on ADC1, so everything has to be done differently.
The code in this commit works perfectly for reading pins on both ADC1 and ADC2 in a non-SensESP project that I've been working on, but I currently have no Signal K / SensESP project going, so I can't really test this properly.