-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add MTA, MWD and VWT sentences #179
Conversation
… sent by NKE Multigraphic
…s; sent by NKE Multigraphic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pr - looks pretty good, some minor review comments.
…n MWD sentence - returns true/magnetic direction whichever is present - returns speed given in m/s if both kn and m/s are present - tests for correct pathes by position
- returns value given in m/s if present, kn and km/h as fallback - tests for calculation of angles, missing data, improper designators
Thank you for your kind reply and the detailed and helpful review! The new commits include:
This is my very first pr in github :-) should I click on the "resolve conversation" buttons or are you going to do that? |
And a fine one it is! I have absolutely no idea if the fields can be in different order, but when not knowing exactly maybe the extra tests are in order. If you want to tweak this to perfection in the ideal world this would be three separate commits, that each add one sentence, but I can merge it like it is and just squash all the commits to one. I don't want to see the whole story, just the end results in master's commit history. |
Thank you! Regarding the order of the fields: at least for MWD it must be fixed because 'M' is used for both 'magnetic' as well as for 'm/s'. In different order it would be ambiguous. Better don't trust any input data - so I think the extra tests are definitely in order. Anything else you'd like me to do? |
Hi,
integrated a NKE instrument system with SignalK.
Added the following sentences (all sent by the NKE Multigraphic) to the NMEA parser:
Thanks for all your great work with SignalK!